Repository navigation
Carry each frame's timestamp across the shmem ring - #15
Merged
Merged
Conversation
The data segment now leads with one float64 timestamp per frame (the buffered axis's value), written before write_index advances, so a reader takes frames and their times from the same slots. Struct version 2. EZShmMirror.timed_view() returns (frames, times, overflow); auto_view is unchanged. ShmemSweepWidget passes the times to phosphor's push_data, so sweep events can be placed on the stream's own clock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shmem ring carried samples only, so
ShmemSweepWidgetpushed data to phosphor with no timestamps. Sweep events, such as marker lines, then had no clock to align against.float64timestamp per frame, the buffered axis's value for that frame. It is written beforewrite_indexadvances, so a reader takes frames and their times from the same slots.ring_views()defines the layout once, and both the writer and the reader use it.EZShmMirror.timed_view(): returns(frames, times, overflow).auto_view()is unchanged.ShmemSweepWidgetpasses the times to phosphor'spush_data.The new test drives the sink in-process, without
ez.run, through a ring wrap, and checks that every frame read back carries the time it was sent with.Pairs with ezmsg-org/phosphor#11. It doesn't require that PR, but its event placement is what uses these times.